This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: Dejagnu: use -isystem to include system header files.
- From: Daniel Jacobowitz <drow at false dot org>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: binutils at sources dot redhat dot com, gdb-patches at sources dot redhat dot com,newlib at sources dot redhat dot com
- Date: Thu, 11 Nov 2004 12:00:20 -0500
- Subject: Re: Dejagnu: use -isystem to include system header files.
- References: <m3pt2koaw8.fsf@redhat.com> <20041111142237.GA25841@nevyn.them.org> <41938BDF.7040104@redhat.com>
On Thu, Nov 11, 2004 at 03:57:19PM +0000, Nick Clifton wrote:
> Hi Daniel,
>
> >This patch will break in-tree testing for yet other targets. I believe
> >arm-elf was affected - anything which does not set
> >NO_IMPLICIT_EXTERN_C. I discussed this with H-P on the dejagnu list
> >but never figured out a solution, but...
>
> >> * lib/libgloss.exp (newlib_include_flags): Use -isystem, not -I.
> >> (libio_include_flags, g++_include_flags, libstdc++_include_flags,
> >> winsup_include_flags): Ditto.
>
> >... I strongly suspect that g++ and winsup should be left out.
>
>
> Ok - what about this revision to the patched sources based upon Rob
> Savoye's suggestion that -isystem is only needed for newlib includes ?
>
> It appears to work for the xstormy16 port and I did not detect any
> regression for the arm-elf port, so I think that it should be OK.
>
> Assuming that you like this patch, shall I submit it to Rob for
> inclusion in the official sources as well ?
I do like it, and I'd appreciate that!
--
Daniel Jacobowitz