This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA/dwarf2] Use SYMBOL_SEARCH_NAME to set type name
- From: Paul Hilfinger <hilfingr at EECS dot Berkeley dot EDU>
- To: Elena Zannoni <ezannoni at redhat dot com>
- Cc: Joel Brobecker <brobecker at gnat dot com>, gdb-patches at sources dot redhat dot com
- Date: Mon, 29 Nov 2004 11:53:45 -0800
- Subject: Re: [RFA/dwarf2] Use SYMBOL_SEARCH_NAME to set type name
>From hilfingr Mon Nov 29 11:29:06 2004
Date: Mon, 29 Nov 2004 01:45:26 -0800
From: "Paul N. Hilfinger" <hilfingr@otisco.mckusick.com>
To: hilfingr@EECS.Berkeley.EDU
Reply-to: Hilfinger@otisco.mckusick.com
X-BTI-AntiSpam: sta:false/3/021,dcc:passed,rbl:off,wlbl:none
References: <200411290224.iAT2OHrd029832@tully.CS.Berkeley.EDU>
Original-recipient: rfc822;hilfingr@imap4.CS.Berkeley.EDU
> Sigh, this is a hack on top af another. Unfortunately the initial
> review of the symtab Ada changes wasn't helpful. I have no choice but
> to let this go in for now, however, please, start thinking of a way to
> get rid of those special cases in SYMBOL_blah_NAME. Making those
> become part of the language vector comes to mind.
Elena,
Would you perhaps elaborate on this critique a bit?
SYMBOL_SEARCH_NAME is, by definition, the name by which a client (in
this case, a language module) looks up an entity, so it would seem
appropriate for this context.
Is your concern that SYMBOL_SEARCH_NAME (and the other SYMBOL_*_NAMEs,
for that matter) involve language-specific tests in their
implementations---i.e., that they are not properly object-orientized?
This of course is a long-standing blotch. If you think it important,
I could fix it (for Ada and C++) as you suggest with some additions to
the language vector. The only annoyance here is that we'd then want to
introduce a new fast mapping from
enum language => struct language_defn *
rather than using the current definition of
language_def (which does a lookup).
Paul