This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: remote.c: parse thread ID's as unsigned values
Daniel Jacobowitz <drow@false.org> writes:
> On Fri, Dec 03, 2004 at 01:48:12PM -0800, Michael Snyder wrote:
> > Jim Blandy wrote:
> > >One month ping.
> >
> > Well heck, I'm not the remote.c maintainer, but I'm the thread
> > maintainer (or one of them).
> >
> > Your change certainly seems reasonable to me. Can't think why
> > we would want thread ids to be sign extended...
> >
> > Under the assumption that you've run into a situation where this
> > is applicable, and the change tests out well, I'll give it the nod.
>
> Fine by me too - but if the manual is unclear, Jim, could you clarify
> it?
I've committed the patch, thanks. How's this for the documentation
change?
2004-12-07 Jim Blandy <jimb@redhat.com>
* gdb.texinfo (General Query Packets): Specify that thread ID's in
the 'qC' and 'qThreadInfo' packets are unsigned hexidecimal
numbers.
Index: gdb/doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.228
diff -c -p -r1.228 gdb.texinfo
*** gdb/doc/gdb.texinfo 7 Dec 2004 11:06:04 -0000 1.228
--- gdb/doc/gdb.texinfo 7 Dec 2004 20:14:33 -0000
*************** Return the current thread id.
*** 20834,20840 ****
Reply:
@table @samp
@item @code{QC}@var{pid}
! Where @var{pid} is a HEX encoded 16 bit process id.
@item *
Any other reply implies the old pid.
@end table
--- 20834,20840 ----
Reply:
@table @samp
@item @code{QC}@var{pid}
! Where @var{pid} is an unsigned hexidecimal process id.
@item *
Any other reply implies the old pid.
@end table
*************** a comma-separated list of thread ids
*** 20863,20872 ****
@end table
In response to each query, the target will reply with a list of one or
! more thread ids, in big-endian hex, separated by commas. @value{GDBN}
! will respond to each reply with a request for more thread ids (using the
! @code{qs} form of the query), until the target responds with @code{l}
! (lower-case el, for @code{'last'}).
@item @code{q}@code{ThreadExtraInfo}@code{,}@var{id} --- extra thread info
--- 20863,20872 ----
@end table
In response to each query, the target will reply with a list of one or
! more thread ids, in big-endian unsigned hex, separated by commas.
! @value{GDBN} will respond to each reply with a request for more thread
! ids (using the @code{qs} form of the query), until the target responds
! with @code{l} (lower-case el, for @code{'last'}).
@item @code{q}@code{ThreadExtraInfo}@code{,}@var{id} --- extra thread info