This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Don't error out when variable not available


Andrew Cagney <cagney@gnu.org> writes:

> Adding more special case code, as was done with your other patch, isn't
> the way to go.

There is really no reason to call error in loclist_read_variable when we
can return VALUE_OPTIMIZED_OUT, like we already to in
dwarf2_evaluate_loc_desc.  Fixing that problem is orthogonal to the
general problem of not catching errors.  That print_frame_args needs to
check for VALUE_OPTIMIZED_OUT is only because it calls val_print directly
without going through value_print.  It already has to take care of NULL
value even though value_print would handle that as well.  Sooner or later
it would probably have been required to add this case anyway.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]