This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [CRIS] Reading core file selects "wrong" mach
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: orjan dot friberg at axis dot com
- Cc: gdb-patches at sources dot redhat dot com, kettenis at gnu dot org, hans-peter dot nilsson at axis dot com
- Date: Fri, 14 Jan 2005 19:40:06 +0100
- Subject: Re: [CRIS] Reading core file selects "wrong" mach
> Date: Fri, 14 Jan 2005 18:10:33 +0100
> From: Orjan Friberg <orjanf@axis.com>
> Maybe there's an easier way to do it - simply call the elf backend before
> processing the program headers, and have the backend set the correct machine
> like they all seem to do already. Since the decision of whether to act on the
> e_flags value is pushed to the elf backend I don't see how this could break
> anything (which I assume could happen if it was done in elf_core_file_p).
Sure. Seems right at a glance, but you should check
elf_backend_object_p of all ports so they don't use data set in
the code around which you moved the call.
> I understand this will have to be sent to the binutils mailing list for
> approval, but I'd appreciate if someone on this list could tell me if it's a
> sane solution.
The people at binutils@ are supposedly more aware of issues
related to this kind of change, meaning you're likely to get
more initiated feedback there regarding the saneness.
mvh H-P