This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: i18n, part 3
- From: "Eli Zaretskii" <eliz at gnu dot org>
- To: Baurjan Ismagulov <ibr at ata dot cs dot hun dot edu dot tr>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Thu, 20 Jan 2005 23:10:31 +0200
- Subject: Re: i18n, part 3
- References: <20050119222228.GA17540@radix50.net>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Wed, 19 Jan 2005 22:22:33 +0000
> From: Baurjan Ismagulov <ibr@ata.cs.hun.edu.tr>
>
> here is the next chunk.
Thanks!
> Comments?
Below.
> Is the following declaration near the end of ax-gdb.c unnecessary?
>
> void _initialize_ax_gdb (void);
No, it isn't unnecessary (under certain command-line options, GCC will
whine if it sees a function definition without a prototype anywhere in
scope).
> - error ("Illegal type cast: intended type must be scalar.");
> + error (_("Illegal type cast: intended type must be scalar."));
Please change "Illegal" into "Invalid" (here and everywhere else in
your patches).
> - error_no_arg ("pcb address");
> + error_no_arg (_("pcb address"));
Should we have an i18n comment here explaining what's a pcb? (You did
that elsewhere in the patch.)
> add_cmd ("pcb", class_obscure, bsd_kvm_pcb_cmd,
> - "Set current context from pcb address", &bsd_kvm_cmdlist);
> + _("Set current context from pcb address"), &bsd_kvm_cmdlist);
Here also.