This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Committed: fix sim subdir make calls
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: cagney at gnu dot org
- Cc: hans-peter dot nilsson at axis dot com, gdb-patches at sources dot redhat dot com
- Date: Sat, 29 Jan 2005 01:57:28 +0100
- Subject: Committed: fix sim subdir make calls
> Date: Fri, 28 Jan 2005 15:49:18 -0500
> From: Andrew Cagney <cagney@gnu.org>
> Ah, ok (thanks). Remember that for GDB anyone can commit configure
> changes and fixes (just ask your self "do you feel lucky" :-).
I felt lucky fixing the sim rules. I think you blew all your
rounds on the sim/common changes. :-)
Before, a failure in any of the sim subdirs didn't stop
compilation. I think you saw that too, yes? Noticed when
letting the --enable-cgen-maint build the generated C files (but
somehow the rules can't really cope with non-existing generated
files, so something like 1+2*#cpu-variants rounds is needed).
When doing that, compilation just continued on, building gdb,
then running the sim test-suite (oops! have to submit & commit
that too) but failing to find the simulator.
I checked briefly that all the rules would be present in the
subdirs, which would possibly be an arguably valid reason to not
fail when the subdir make fails.
2005-01-29 Hans-Peter Nilsson <hp@axis.com>
* Makefile.in (all, clean mostlyclean, distclean maintainer-clean)
(realclean, install): Fail if subdir make failed.
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/sim/Makefile.in,v
retrieving revision 1.5
diff -p -c -u -p -r1.5 Makefile.in
cvs diff: conflicting specifications of output style
--- Makefile.in 12 Jan 2005 16:23:11 -0000 1.5
+++ Makefile.in 29 Jan 2005 00:46:14 -0000
@@ -130,7 +130,7 @@ all:
if [ "$$dir" = "." ]; then \
true; \
elif [ -d $$dir ]; then \
- (cd $$dir; $(MAKE) $(FLAGS_TO_PASS)); \
+ (cd $$dir; $(MAKE) $(FLAGS_TO_PASS)) || exit 1; \
else true; fi; \
done
@@ -140,7 +140,7 @@ clean mostlyclean:
if [ "$$dir" = "." ]; then \
true; \
elif [ -d $$dir ]; then \
- (cd $$dir; $(MAKE) $(FLAGS_TO_PASS) $@); \
+ (cd $$dir; $(MAKE) $(FLAGS_TO_PASS) $@) || exit 1; \
else true; fi; \
done
@@ -150,7 +150,7 @@ distclean maintainer-clean realclean:
if [ "$$dir" = "." ]; then \
true; \
elif [ -d $$dir ]; then \
- (cd $$dir; $(MAKE) $(FLAGS_TO_PASS) $@); \
+ (cd $$dir; $(MAKE) $(FLAGS_TO_PASS) $@) || exit 1; \
else true; fi; \
done
rm -f Makefile config.cache config.log config.status
@@ -161,7 +161,7 @@ install:
if [ "$$dir" = "." ]; then \
true; \
elif [ -d $$dir ]; then \
- (cd $$dir; $(MAKE) $(FLAGS_TO_PASS) install); \
+ (cd $$dir; $(MAKE) $(FLAGS_TO_PASS) install) || exit 1; \
else true; fi; \
done
brgds, H-P