Re: [gdbserver/patch] Z packet support

[Daniel Jacobowitz <drow at false dot org>]

On Tue, Feb 01, 2005 at 01:08:07PM +0100, Orjan Friberg wrote:
> Daniel Jacobowitz wrote:
> >
> >You missed the most important problem with the previous posting, I'm
> >afraid - it's still whitespace mangled.  Please don't send patches
> >using format=flowed; it's very good for text, but lousy for data.
> >Either disable it or just attach them.  I've more or less figured out
> >the algorithm by which it ate your patch, but it's pretty tedious to
> >hand-merge; could you resend?
> 
> Sure.  (Until I figure it out, I'll be attaching patches instead of 
> inlining them.  Sorry for the trouble.)
> 
> >CORE_ADDR is always a long long in gdbserver, so your sizeof (addr)
> >probably doesn't work right for 32-bit targets.  I guess sizeof (void
> >*) is always right for this, though... at least for the kinds of
> >targets gdbserver supports now.
> 
> FWIW, recurse.exp and watchpoints.exp ran fine on CRISv32 (32-bit target) 
> when a 64-bit address was sent.  I changed it nonetheless, and tweaked the 
> comment.

I was going to implement the matching bits for i386, but never found
the time.  No point in my holding up your work any longer.  I am still
not clear on how this will handle threads but it sounds like CRIS
kernel bugs mean that that doesn't matter to you; it's irrelevant if
you've only got one copy of the debug registers.  I may come back to
revisit the names of the functions if anyone ever implements hardware
breakpoint support.

The patch is OK.  Please make sure to include a full changelog entry,
and update the copyright years in any files you touch.


-- 
Daniel Jacobowitz
CodeSourcery, LLC