Re: PATCH: Refactor ser-unix.c

[Mark Kettenis <mark dot kettenis at xs4all dot nl>]

   Date: Tue, 22 Mar 2005 00:17:03 -0800
   From: Mark Mitchell <mark@codesourcery.com>

   This patch splits ser-unix.c into two files:

   * ser-base.c, which contains functions that have nothing to do with
     UNIX, and

   * ser-unix.c, which contains functions that are either (a)
     UNIX-specific, or (b) deal with the "hardwire" serial interface.

   The purpose of this patch is that for non-Cygwin Windows, we want the
   functions in ser-base.c, but not those in ser-unix.c.

Makes sense to me.

   There are no changes to any of the routines; this is purely code
   motion.

   In order to keep the patch easiser to read, I did not rename the
   ser-base.c routines with a ser_base prefix instead of the current
   ser_unix prefix, but I would like to make that change before
   check-in.

Yes, please; the ser_unix prefix doesn't really make sense for the
functions in set-base.c.  I presume is also makes sense to drop the
_nop_ in that operation.  You may check in this patch and than do the
rename in a seperate patch, or do it both at once.  Consider the
rename patch pre-approved.

Mark