This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[commit] incremental improvements to mn10300
- From: Michael Snyder <msnyder at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Fri, 01 Apr 2005 16:37:06 -0800
- Subject: [commit] incremental improvements to mn10300
- Organization: Red Hat, Inc.
2005-04-01 Michael Snyder <msnyder@redhat.com>
* mn10300-prologue.c (set_movm_offsets): Don't test variable
before setting it.
* mn10300-tdep.c (mn10300_skip_prologue): Use analyze_prologue
instead of skip_prologue_using_sal.
Index: mn10300-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mn10300-tdep.c,v
retrieving revision 1.119
diff -p -r1.119 mn10300-tdep.c
*** mn10300-tdep.c 21 Mar 2005 19:31:46 -0000 1.119
--- mn10300-tdep.c 2 Apr 2005 00:04:44 -0000
*************** mn10300_breakpoint_from_pc (CORE_ADDR *b
*** 295,303 ****
static CORE_ADDR
mn10300_skip_prologue (CORE_ADDR pc)
{
/* FIXME: not implemented. */
/* First approximation, try simply using skip_prologue_using_sal. */
! return skip_prologue_using_sal (pc);
}
/* Simple frame_unwind_cache.
--- 295,309 ----
static CORE_ADDR
mn10300_skip_prologue (CORE_ADDR pc)
{
+ #if 0
+ CORE_ADDR ret;
/* FIXME: not implemented. */
/* First approximation, try simply using skip_prologue_using_sal. */
! ret = skip_prologue_using_sal (pc);
! return ret ? ret : pc;
! #else
! return mn10300_analyze_prologue (NULL, NULL, pc);
! #endif
}
/* Simple frame_unwind_cache.
Index: mn10300-prologue.c
===================================================================
RCS file: /cvs/src/src/gdb/mn10300-prologue.c,v
retrieving revision 1.2
diff -p -r1.2 mn10300-prologue.c
*** mn10300-prologue.c 21 Mar 2005 23:23:32 -0000 1.2
--- mn10300-prologue.c 2 Apr 2005 00:03:25 -0000
*************** set_movm_offsets (struct frame_info *fi,
*** 119,128 ****
int offset = 0;
CORE_ADDR base;
! if (cache == NULL || fi == NULL)
return;
cache = mn10300_frame_unwind_cache (fi, this_cache);
base = trad_frame_get_this_base (cache);
if (movm_args & movm_other_bit)
{
--- 119,131 ----
int offset = 0;
CORE_ADDR base;
! if (fi == NULL || this_cache == NULL)
return;
cache = mn10300_frame_unwind_cache (fi, this_cache);
+ if (cache == NULL)
+ return;
+
base = trad_frame_get_this_base (cache);
if (movm_args & movm_other_bit)
{