This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch] update gdb.base/so-impl-ld.exp to use new shared library infrastructure
- From: Daniel Jacobowitz <drow at false dot org>
- To: Paul Gilliam <pgilliam at us dot ibm dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Thu, 14 Apr 2005 15:32:52 -0400
- Subject: Re: [patch] update gdb.base/so-impl-ld.exp to use new shared library infrastructure
- References: <200504140955.01606.pgilliam@us.ibm.com>
I just noticed that all of your patches I approved this afternoon
add new calls to gdb_suppress_entire_file; on first reading I thought
they were just moving that bit around. Please don't add new calls to
that function. Call "untested" with a message and then return -1
instead.
On Thu, Apr 14, 2005 at 08:55:01AM -0800, Paul Gilliam wrote:
> - # This test is presently only valid on HP-UX, since it requires
> - # that we use HP-UX-specific compiler & linker options to build
> - # the testcase.
> - # Actually this test works on solaris, and linux too.
> -
> - if {! ([istarget "hppa*-*-*hpux*"]
> - || [istarget "sparc-sun-solaris*"]
> - || [istarget "*-*-linux-gnu*"]) } {
> - return
> - }
Specifically, this means the test was previously quiet on platforms
which couldn't build shared libraries. Now it's going to be very
noisy.
> ! if {$hp_cc_compiler} {
> ! set additional_flags "additional_flags=-Ae"
> ! } else {
> ! set additional_flags ""
> ! }
The shared library helpers don't subsume this bit.
--
Daniel Jacobowitz
CodeSourcery, LLC