This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: respect -k or its absence when building sim subdirs
On Thu, Apr 14, 2005 at 07:20:06PM -0500, Jim Blandy wrote:
>
> Daniel Jacobowitz <drow@false.org> writes:
> > On Wed, Apr 13, 2005 at 12:32:23PM -0500, Jim Blandy wrote:
> > >
> > > Overkill, probably. I just hate this kind of stuff.
> > >
> > > 2005-04-13 Jim Blandy <jimb@redhat.com>
> > >
> > > Fix -k handling when looping over subdirectories.
> > > * for-subdirs.sh: New script.
> > > * Makefile.in (all clean mostlyclean distclean maintainer-clean
> > > realclean install): Use it to loop over subdirectories.
> >
> > Wow... this really is overkill, and I'm not sure that the quoting does
> > what you want it to. Can't you do this in make more straightforwardly?
> > I know you can in GNU make, anyway.
>
> Can you suggest a strategy? Whatever you do, you have to replicate it
> in each of those targets. If it's not pretty trivial, I don't want to
> write it out every time; it belongs in a "function", which, in this
> world, is a script.
>
> After I posted, I realized the quoting could be simplified to:
>
> clean mostlyclean:
> @rootme=`pwd` ; export rootme ; \
> ! $(SHELL) $(srcdir)/for-subdirs.sh \
> ! "$(MAKEFLAGS)" '$(MAKE) $(FLAGS_TO_PASS) $@' $(SUBDIRS)
>
>
> Where else were you worried about the quoting?
Single or double quotation marks in the arguments. Particularly
plausible in $(FLAGS_TO_PASS). Make variable substitution is really
pretty dumb. I'm not sure it's a real problem.
All you want is, iff MAKEFLAGS does not contain -k, to exit if any
submake fails. I don't know what Make bits are and are not portable
very well. You can do this in shell; something like:
if ! $(MAKE) -C subdir; then
if ! echo "$(MAKEFLAGS)" | grep '^[^ ]*k' > /dev/null; then
exit 1
fi
fi
And that whole inner goo can become $(MAKE_K_CHECK).
--
Daniel Jacobowitz
CodeSourcery, LLC