Re: PATCH: Support Windows in event-loop.c

[Mark Mitchell <mark at codesourcery dot com>]

Christopher Faylor wrote:
> On Mon, Apr 25, 2005 at 02:46:00PM -0700, Mark Mitchell wrote:
>
> > Eli Zaretskii wrote:
> >
> > > > Date: Mon, 25 Apr 2005 13:22:16 -0700
> > > > From: Mark Mitchell <mark@codesourcery.com>
> > > >
> > > > Here is the revised patch.  As per previous discussion, this version 
> > > > still has the limitation that it only works with consoles -- but it 
> > > > would be possible to use threads within gdb_select to extend it to work 
> > > > with a wider variety of handles.  In any case, this patch provides 
> > > > useful functionality on Windows, and does not impose the Windows API on 
> > > > generic code.
> > >
> > >
> > > This patch is fine with me.
> >
> > Thanks, committed.
>
>
> Wow.  That was fast.

Sorry, did I misinterpret Eli's message?  I took it as a commit 
approval, but perhaps that was overly optimistic?

> The patch was ok with me, too, but it seems like you should be checking
> the bounds of the handles array just in the off chance that readfds is >
> 63.  I know that it is probably vanishingly unlikely that this could ever
> occur but it still seems like good practice nonetheless.

OK.  May I consider a patch to add the appropriate gdb_assert obvious?

Thanks,

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304