This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFC/RFA] Set current language when dumping symtab
- From: Daniel Jacobowitz <drow at false dot org>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Tue, 31 May 2005 21:59:52 -0400
- Subject: Re: [RFC/RFA] Set current language when dumping symtab
- References: <20050504001955.GE2439@adacore.com> <20050528234905.GF22435@nevyn.them.org> <20050529021056.GF18754@adacore.com> <20050529025401.GA14380@nevyn.them.org> <20050530054538.GM18754@adacore.com> <20050530195338.GO18754@adacore.com> <20050530195458.GB31201@nevyn.them.org> <20050601012932.GK2014@adacore.com>
On Tue, May 31, 2005 at 06:29:32PM -0700, Joel Brobecker wrote:
> > and there's no reason not to fold this into dump_symtab.
>
> I tend to still prefer the folding, because I find it clearer
> that way. And if for any reason we change the implementation of
> dump_symtab_1 to have an early return somewhere in the code, we're
> not in danger of forgetting to reset the language.
>
> But I'm happy either way. Let me know which you prefer, and I'll
> submit a new patch.
OK - you have a good reason, that's enough for me :-)
--
Daniel Jacobowitz
CodeSourcery, LLC