This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Hooks still needed for annotations


On Thu, Jun 02, 2005 at 09:32:31AM +1200, Nick Roberts wrote:
> I don't currently use breakpoints-invalid but I might wish to at one stage.
> I want to ensure that annotations aren't quietly removed by dismantling them
> bit by bit.

If that's what you want to accomplish, your patch should include test
cases for these annotations.  Otherwise they're likely to be "cleaned
up".  Also, please do not comment out code; if it's wrong, it should be
deleted.

(I didn't look in to the substance of the patch yet, just this
discussion.)

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]