This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Take III, part 2: am33 linux corefile support
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: msnyder at redhat dot com
- Cc: gdb-patches at sources dot redhat dot com, drow at false dot org
- Date: Tue, 28 Jun 2005 23:08:26 +0200 (CEST)
- Subject: Re: [RFA] Take III, part 2: am33 linux corefile support
- References: <42C09C74.1010507@redhat.com>
Date: Mon, 27 Jun 2005 17:40:20 -0700
From: Michael Snyder <msnyder@redhat.com>
OK, here's this part again. Mark, I used the osabi mechanism
to register my corefile handlers, and I changed the typedefs
from unsigned char to gdb_byte.
Great! But I have the same question as Daniel regarding the need for
the sniffer. Please make am33_regset_from_core_section static and
remove the prototype from mn10300-tdep.h. That removes the need to
include "regset.h" there[1]. Oh, and please remove the needless (void
*) cast in the register_raw_supply and register_raw_collect calls.
Be advised that there are Linux systems out there that leak things in
the ELF_ and elf_ "namespaces". This code won't compile on those
systems.
Mark
[1] Which shouldn't have been done in the first place; a forward
"struct regset" declaration would have been enough.