This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch for gdb/configure cleanup (autoheader warnings)


On Sun, Jul 03, 2005 at 08:33:37AM -0700, Steve Ellcey wrote:
> OK, here is the patch again with the changelog file updated (all I added
> was the comment after 'configure.ac:'.  There are too many AC_DEFINE
> statments changed to list them all.  There were no changes to
> configure.ac other than adding the 2nd and 3rd arguments to the
> AC_DEFINE calls.
> 
> As for XM_FILE, I am willing to kill it, but I would rather do that in a
> separate patch so why don't I leave it here and I can then do a new
> patch to remove it completely from the various config, header, and C
> files.

Definitely.  This patch is OK.

> 2005-07-01  Steve Ellcey  <sje@cup.hp.com>
> 
> 	* configure.ac (AC_DEFINE): Add args to AC_DEFINE calls.

Please use this instead:
	* configure.ac: Add arguments to AC_DEFINE calls.

You aren't changing AC_DEFINE itself.

> 	* acconfig.h: Remove file.
> 	* acinclude.m4 (AC_GNU_SOURCE): Remove definition.
> 	* configure: Regenerate.
> 	* config.in: Regenerate.


-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]