This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: PATCH: More ISO-ifying of sim/common
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Ben Elliston <bje at au1 dot ibm dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sat, 9 Jul 2005 01:51:38 -0400 (EDT)
- Subject: Re: PATCH: More ISO-ifying of sim/common
- References: <42CE3031.1010907@au.ibm.com>
Hi Ben.
On Fri, 8 Jul 2005, Ben Elliston wrote:
> Index: sim-load.c
> @@ -196,17 +186,11 @@ xprintf VPARAMS ((host_callback *callbac
> static void
> eprintf VPARAMS ((host_callback *callback, const char *fmt, ...))
> {
> -#ifndef ANSI_PROTOTYPES
> host_callback *callback;
> char *fmt;
> -#endif
> va_list ap;
>
> VA_START (ap, fmt);
> -#ifndef ANSI_PROTOTYPES
> - callback = va_arg (ap, host_callback *);
> - fmt = va_arg (ap, char *);
> -#endif
The first should have been like the second. This breaks build
with gcc-4. (But not with e.g. gcc-3.3 for some uninteresting
reason.)
brgds, H-P