Re: PATCH: tests for MI commands

[Nick Roberts <nickrob at snap dot net dot nz>]

Daniel Jacobowitz writes:
 >                                                            ...But it
 > looks like these failures are related to your change:
 > 
 > +FAIL: gdb.mi/mi-var-child.exp: listing of children, simple types: names, type and values, complex types: names and types

I don't get this failure (this is one file I did test!).

 > +FAIL: gdb.mi/mi-var-display.exp: get children local variable weird

I think this test should be removed as there was an identical test in
mi-var-child.exp (which I have now modified for 12 elements).

 > +FAIL: gdb.mi/mi2-stack.exp: stack locals listing 0
 > +FAIL: gdb.mi/mi2-stack.exp: next in callee4 (timeout)
 > +FAIL: gdb.mi/mi2-stack.exp: stack locals listing 1
 > +FAIL: gdb.mi/mi2-var-child.exp: get children of struct_declarations
 > +FAIL: gdb.mi/mi2-var-child.exp: get children of struct_declarations.long_array
 > +FAIL: gdb.mi/mi2-var-child.exp: get number of children of struct_declarations.long_array
 > +FAIL: gdb.mi/mi2-var-child.exp: get children of weird
 > +FAIL: gdb.mi/mi2-var-child.exp: get children of weird.long_array
 > +FAIL: gdb.mi/mi2-var-child.exp: get number of children of weird.long_array
 > +FAIL: gdb.mi/mi2-var-child.exp: delete var weird
 > +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_a0_0 (stopped at wrong place)
 > +FAIL: gdb.mi/mi2-var-child.exp: delete var struct_declarations
 > +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 1 (stopped at wrong place)
 > +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 2 (stopped at wrong place)
 > +ERROR: Got interactive prompt.
 > +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->char_ptr (and 0.char_ptr) changed
 > +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 3 (timeout)
 > +ERROR: Got interactive prompt.
 > +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->char_ptr (and 1.char_ptr) changed
 > +ERROR: Couldn't send -var-update * to GDB.
 > +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->next->char_ptr (and 2.char_ptr) chang ed
 > +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 5 (timeout)
 > +ERROR: Couldn't send -var-update * to GDB.
 > +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->long_ptr (and 0.long_ptr) changed
 > +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 6 (timeout)
 > +ERROR: Couldn't send -var-update * to GDB.
 > +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->long_ptr (and 1.long_ptr) changed
 > +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 7 (timeout)
 > +ERROR: Couldn't send -var-update * to GDB.
 > +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->next->long_ptr (and 2.long_ptr) changed
 > +FAIL: gdb.mi/mi2-var-display.exp: get children local variable weird
 >
 > Please fix them - I think the easiest thing to do is to revert the
 > changes to the affected source files and switch those two modified
 > tests to using new source files.

Given the scarce resources for this unpaid work I ask you again to consider
removing the mi2-*.exp files and just test the current version of MI.  The
reality is that they serve no useful purpose (mi-*.exp tests would still
pass if GDB was invoked with "-i=mi2") and they require effort that could
be better spent on other things.

 > As a side note, the trick to getting the CVS logs to come out right is
 > not just to use the same commit message for every file, but to commit
 > them together in a single invocation of cvs.  See the mailing list
 > archives for gdb-cvs to see the difference.

I can see the difference in the archive but not the CVS logs.  I commit using
VC in Emacs which seems to require separate commits but I'll work out how to
do this as one commit for next time.

Nick