This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: PATCH: tests for MI commands
> > I never intended to leave things broken. You have asked me to fix the
> > failures, and I will, but I'm not sure if that means submit further
> > patches to the mailing list or commit appropriate fixes. Based on Mark
> > Kettenis' e-mail,
>
> Submit patches, please.
OK.
> > I attach a simple fix for mi-var-child.exp. Does it work in your case? I
>
> > 2005-07-28 Nick Roberts <nickrob@snap.net.nz>
> >
> > * gdb.mi/mi-var-child.exp: Allow struct_declarations.character to be
> > uninitialized.
>
> First of all, it won't work. You added:
> value=\"0 '\\\\\\\\$decimal'\"
> which still has 0 in it :-)
Oops!
> Second, I get a value of 0 here, but the test still fails.
> func_ptr_struct and func_ptr_ptr aren't initialized either. Chasing
> uninitialized members is going to leave the tests script a bit of a
> mess.
>
> Initializing the whole structure proved to be a bit of a pain - these
> tests are ridiculously tricky to edit. But here it is. Tested on
> i686-pc-linux-gnu and committed. I hope this will be more useful if we
> add any additional value-related tests.
I find the number of backslashes needed confusing (because of the read syntax
for strings?). Your changes seem concise. I'll test these too.
Thanks again.
Nick