This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: MI testsuite to use PTY for inferior
- From: Bob Rossi <bob at brasko dot net>
- To: Nick Roberts <nickrob at snap dot net dot nz>, gdb-patches at sources dot redhat dot com,Daniel Jacobowitz <drow at false dot org>
- Date: Wed, 3 Aug 2005 08:47:53 -0400
- Subject: Re: MI testsuite to use PTY for inferior
- References: <17131.5769.342629.658975@farnswood.snap.net.nz> <20050730173855.GA21401@white> <17131.64575.780190.163527@farnswood.snap.net.nz> <20050730230309.GA22547@white> <20050731012111.GB13808@nevyn.them.org> <20050803020653.GC29999@white>
On Tue, Aug 02, 2005 at 10:06:53PM -0400, Bob Rossi wrote:
> On Sat, Jul 30, 2005 at 09:21:11PM -0400, Daniel Jacobowitz wrote:
> > On Sat, Jul 30, 2005 at 07:03:09PM -0400, Bob Rossi wrote:
> > > However, since that's pretty ugly, I'll take your suggestion and always
> > > create and assign inferior_pty a value. Then I'll check it for the value
> > > of "true" before executing any code.
> >
> > I recommend doing something different. Make the argument a flag, i.e.
> > "mi_gdb_start use-tty". Or "no-tty" depending on what you want the
> > default to be.
>
> Here is an updated patch with all the suggestions made so far, except
> for the ChangeLog suggestion Nick made. Nick, thanks for noticing the
> problems with the original patch!
>
> If preferred, I could add the separate-inferior-tty argument to
> mi_gdb_start only in the tests that need that functionality to pass,
> instead of for all the mi-* tests. This would reduce the patch size
> significantly.
BTW, one other small note. If there is inferior data to match, and the
user pass's GDB's output and the inferior's output to gdb_mi_test, 2
PASS's will get generated, instead of one. I don't know if this is the
desirable way to do this.
Bob Rossi