This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: fix "too much information" bug w/ "info vector" on PowerPC
- From: Jim Blandy <jimb at redhat dot com>
- To: pgilliam at us dot ibm dot com
- Cc: gdb-patches at sources dot redhat dot com
- Date: Tue, 30 Aug 2005 14:42:31 -0700
- Subject: Re: fix "too much information" bug w/ "info vector" on PowerPC
- References: <200508301459.57189.pgilliam@us.ibm.com>
Paul Gilliam <pgilliam@us.ibm.com> writes:
> I was temped to commit this is obvious, but wanted the warm fuzzy of
> peer review.
Well, you can have the cold slimy of a review from me. :)
Yes, that looks right. Comments:
- Could you also add comments above the definitions of
tdep->ppc_vr0_regnum and tdep->ppc_ev0_regnum in ppc-tdep.h?
Perhaps such comments could have prevented the bugs's appearance in
the first place.
- I'm not sure why the indentation in your patch is weird, but in any
case, there seems to be a preference for using spaces in new code,
not tabs.
Thanks!