This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fix "too much information" bug w/ "info vector" on PowerPC


On Wed, Aug 31, 2005 at 01:23:15PM -0700, Paul Gilliam wrote:
> Here is the new patch with comments added/chanded in ppc-tdep.h
> 
> If I hear no objections, I'll commit this tomorrow.

Kevin's OK'd it, so go ahead.  But:

> 2005-08-30  Paul Gilliam <pgilliam@us.ibm.com>
> 
>         * ppc-tdep.h: better explanation of using -1 for nonexistant registers
>         * rs6000-tdep.c (rs6000_register_reggroup_p): don't assume that
>         tdep->ppc_vr0_regnum or tdep->ppc_ev0_regnum are not -1

	* ppc-tdep.h (struct gdbarch_tdep): Better explanation of using
	-1 for nonexistant registers.
	* rs6000-tdep.c (rs6000_register_reggroup_p): Don't assume that
	tdep->ppc_vr0_regnum and tdep->ppc_ev0_regnum are not -1.
> !     /* Not all PPC and RS6000 variants will have the registers
> !        represented below.  A -1 is used to indicate that the register
> !        is not present in this variant. */

Two spaces after periods please, here and below.  Also end comments
with periods where you didn't.  Yes, I realize the file is inconsistent
about this.


-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]