This is the mail archive of the
mailing list for the GDB project.
Re: fix "too much information" bug w/ "info vector" on PowerPC
- From: Jim Blandy <jimb at redhat dot com>
- To: pgilliam at us dot ibm dot com
- Cc: gdb-patches at sources dot redhat dot com, Daniel Jacobowitz <drow at false dot org>
- Date: Thu, 01 Sep 2005 16:06:08 -0700
- Subject: Re: fix "too much information" bug w/ "info vector" on PowerPC
- References: <email@example.com><firstname.lastname@example.org><20050831203248.GA18491@nevyn.them.org><email@example.com>
Paul Gilliam <firstname.lastname@example.org> writes:
> Talking about spaces, tabs, and formatting, I noticed that some of the function prototypes in ppc-tdep.h are over 80 columns and
> real ugly.
> Here, for your consideration, are two patches to change that: one uses a short-lived macro (ppc-tdep.patch) and the other uses a
> typedef (newest.patch).
If I were to use a typedef, I'd put it in gdbarch.h and call it
gdb_retval_convention_t; there's nothing special about ppc-tdep.h's
The following is also legal C, Emacs-friendly, and gdb_indent.sh-friendly:
enum return_value_convention (ppc_sysv_abi_return_value
(struct gdbarch *gdbarch,
struct type *valtype,
struct regcache *regcache,
const gdb_byte *writebuf));
I used this once before, but Mark Kettenis declared it "weird" or
something and asked me to take it out. :) Be that as it may, I think
it's better than the macro or the local typedef.