This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add vscr register to 'list' of PowerPC vector registers.


On Fri, Oct 14, 2005 at 12:13:20PM -0700, Paul Gilliam wrote:
> The vscr regisgter was omitted from the if statement in rs6000-tdep.c that decides if a register is a vector register.
> Consiquetly, it was not printed along with the other vector registers using the 'info vector' command.
> 
> Two patches follow:  the first fixes the problem with the least amount of fuss.
> 
> The second adds ppc_vscr_regnum to the gdbarch_tdep struct in ppc-tdep.h and then uses that.
> This version was prompted by this comment in rs6000-tdep.c:
>        /* FIXME: jimb/2004-07-15: when we have tdep->ppc_vscr_regnum,
>           we can treat this more like the other cases.  */
> 
> Which should i commit?

You should also try posting patches using a readable diff format :-)
(unified, please, or at least context).

I have no preferences on the actual patch.


-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]