This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA/RFC] Support DW_OP_breg for tracepoints

From: Randolph Chung <randolph at tausq dot org>
To: Jim Blandy <jimb at red-bean dot com>
Cc: gdb-patches at sources dot redhat dot com
Date: Mon, 14 Nov 2005 07:48:27 +0800
Subject: Re: [RFA/RFC] Support DW_OP_breg for tracepoints
References: <43775DDB.6020408@tausq.org> <8f2776cb0511131539j17ae5144n87b1aedab1fa420e@mail.gmail.com>

Why are you adding the offset twice?  Is it just cut-and-paste from
the DW_OP_fbreg code?  That looks wrong, too.

Yes, copy and paste. I don't understand why it's added twice either :) Dan seems to think it's ok, but I'll wait a bit before I commit anything.

This code should go in ax-gdb.[ch].  That has a translator from GDB
expressions to agent expressions; it would make sense to also have a
translator from Dwarf expressions to agent expressions.

I don't feel comfortable enough with the dwarf code to touch this, so I'll have to leave this part to one of you experts :)

randolph

Follow-Ups:
- Re: [RFA/RFC] Support DW_OP_breg for tracepoints
  - From: Daniel Jacobowitz

References:
- [RFA/RFC] Support DW_OP_breg for tracepoints
  - From: Randolph Chung
- Re: [RFA/RFC] Support DW_OP_breg for tracepoints
  - From: Jim Blandy

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]