This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [hppa-hpux] Signal frame unwinding support for hppa64-hp-hpux11.11


> Date: Thu, 17 Nov 2005 12:47:50 +0800
> From: Randolph Chung <randolph@tausq.org>
> 
> The attached patch adds support for signal frame unwinding under
> hppa64-hp-hpux11.11, and fixes a bug with signal frame unwinding under
> hppa2.0w-hp-hpux11.11. I will commit this in a day or no if there are no
> comments.
> 
> 2005-11-15  Randolph Chung  <tausq@debian.org>
> 
> 	* hppa-hpux-tdep.c (hppa_hpux_sigtramp_frame_unwind_cache): Ensure "off"
> 	is large enough to hold 64-bit offset.  Set proper signal context offset
> 	for 64-bit programs.  Set pc properly for signal frames.

Please reformat the ChangeLog entry before you commit; the lines are too long!

> Index: hppa-hpux-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/hppa-hpux-tdep.c,v
> retrieving revision 1.43
> diff -u -p -r1.43 hppa-hpux-tdep.c
> --- hppa-hpux-tdep.c	29 Oct 2005 21:31:45 -0000	1.43
> +++ hppa-hpux-tdep.c	15 Nov 2005 15:40:07 -0000
> @@ -1188,7 +1192,7 @@ hppa_hpux_sigtramp_frame_unwind_cache (s
>    else
>      {
>        /* Wide registers. */
> -      off = scptr + offsetof (save_state_t, ss_wide) + 8;
> +      off = scptr + offsetof (save_state_t, ss_wide.ss_64) + 8;
>        incr = 8;
>        szoff = (tdep->bytes_per_address == 4 ? 4 : 0);
>      }
> @@ -1203,11 +1207,15 @@ hppa_hpux_sigtramp_frame_unwind_cache (s

Hmm, why is this chunk needed?  AFAICT it shouldn't make a difference
and I have a preference for using a plain ss_wide).

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]