This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] init-if-undefined command


On Wed, Nov 30, 2005 at 02:12:33PM +0000, Andrew STUBBS wrote:
> +      printf_unfiltered ("Init-if-undefined requires an assignment expression.\n");

Is there any reason this, and the other outputs, should not be
_("gettextized")?

Also, should this be an error()?

> +  /* Extract the variable from the parsed expression.
> +     In the case of an assign the lvalue will be in elts[1] and elts[2].  */
> +  if (expr->elts[1].opcode != OP_INTERNALVAR)
> +    {
> +      printf_unfiltered ("The first parameter to init-if-undefined should be a GDB variable\n");
> +      do_cleanups (old_chain);
> +      return;
> +    }

Ditto.


-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]