This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] implement gcore on hp/ux

From: Joel Brobecker <brobecker at adacore dot com>
To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
Cc: gdb-patches at sources dot redhat dot com
Date: Wed, 11 Jan 2006 07:59:29 +0400
Subject: Re: [RFA] implement gcore on hp/ux
References: <20060110171752.GL925@adacore.com> <200601102029.k0AKTfPh011880@elgar.sibelius.xs4all.nl>

> I'm not sure I like the exec_set_write_core_file() hack.  Targets
> should really do this the proper way, initializing their target vector
> properly.  Can't you get rid of it by setting to_write_core_file in
> procfs.c:init_ptoc_ops() and linux-nat.c:linux_target()?

Yes, absolutely. I think I also need to do that for FreeBSD and
probably Solaris too (IIRC), right?

> The HP-UX code looks good, but could you please use xsnprintf()
> instead of sprintf()?

Oops, good catch. Will fix that as well.

Thanks for the review.
-- 
Joel

References:
- [RFA] implement gcore on hp/ux
  - From: Joel Brobecker
- Re: [RFA] implement gcore on hp/ux
  - From: Mark Kettenis

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]