This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ob] More warnings; Call for assistance


On Tue, Jan 17, 2006 at 11:04:33PM +0200, Eli Zaretskii wrote:
> I have this:
> 
>    http://lists.gnu.org/archive/html/emacs-devel/2005-12/msg01743.html
> 
> I don't know if this counts as a reference, but it's good enough for
> me ;-)

I've seen no sign of this change in GCC.  I will follow up with them.

> > Also, do you think the warning is useless?
> 
> I think it's too pedantic; I think it's a false alarm 99.99% of the
> time.  But if you think I'm wrong, please describe situations where
> this warning would point to a real trouble.

I've fixed several places where we passed ints as var_uinteger or
unsigned ints as var_zinteger to the CLI.  They're a bit subtle to fix
(witness my earlier message today about set complaints -1).  They've
never bitten us, but they could.

> > If you think it's useless, I'll just stop, and we'll go with Mark's
> > patch to disable it.
> 
> Hmm.. were you fixing only this precise warning?  I thought I've seen
> other, more serious warnings as well fixed by your recent changes.

I fixed I believe two warnings other than this, caused by unrelated
changes in GCC.  The bulk are for this issue.

Shall we discard the remaining (more minor) cases and turn off this
warning?

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]