This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ob] More warnings; Call for assistance


> Date: Tue, 17 Jan 2006 16:14:55 -0500
> From: Daniel Jacobowitz <drow@false.org>
> Cc: gdb-patches@sourceware.org
> 
> I've fixed several places where we passed ints as var_uinteger or
> unsigned ints as var_zinteger to the CLI.  They're a bit subtle to fix
> (witness my earlier message today about set complaints -1).  They've
> never bitten us, but they could.

These cases indeed need fixing, since they reveal unclean code.  If
there are more of them, I think we should fix them too.  But the bulk
of these warnings are not for this kind of problems.  I especially
dislike these warnings when the pointer is passed to a library
function.

> Shall we discard the remaining (more minor) cases and turn off this
> warning?

I think so, yes.  We have better uses for our energy right now.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]