This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Tuesday 17 January 2006 11:28, you wrote: > > From: Paul Gilliam <pgilliam@us.ibm.com> > > Date: Mon, 16 Jan 2006 19:15:54 -0800 > > > > Mark, > > > > I have made the modifications you asked for. > > > > I would have committed the patch, but I wanted to give you a chance > > to see if my new variable name was ok: fr became curfrm. > > > > It's still a little criptic, but I was trying to avoid making the > > condition of an 'if' statement be on two lines. > > Ah, that's a good reason not too make variables and function names > overly long. Personally I'd just named the varible "frame" (that > actually would make the function future safe, since it really should > work for any frame, and take a frame argument instead of a pc, but > that's not your fault.) > > > OK to commit? > > I'll leave it up to you to change curfrm into frame as suggested > above. So, yes. Thanks!
Attachment:
watch-locals.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |