This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Arm prologe skipping broken on 64-bit hosts


On Wed, 2006-02-15 at 03:02, Paul Brook wrote:
> This time with the patch.
> 
> On Wednesday 15 February 2006 01:37, Paul Brook wrote:
> > The Arm prologue skipping code is broken on 64-bit hosts. The problem is
> > that the opcode is loaded as a signed integer, then stored in an "unsigned
> > long". This is then compared against unsigned 32-bit constants.
> >
> > The attached patch fixes this by reading the instruction as an unsigned
> > value. For consistency I made the same change in other similar routines.
> >
> > Tested with cross to arm-none-eabi.
> > Ok?
> >
> > Paul
> >
> > 2006-02-15  Paul Brook  <paul@codesourcery.com>
> >
> > 	* arm-tdep.c (arm_skip_prologue, thumb_get_next_pc, arm_get_next_pc):
> > 	Load insn opcodes as unsigned values.

OK.

R.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]