This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: ensure binary objects opened in binary mode
- From: Christopher Faylor <cgf-please-use-the-mailinglist at sourceware dot org>
- To: gdb-patches at sourceware dot org, Charles Wilson <cygwin at cwilson dot fastmail dot fm>
- Date: Fri, 17 Feb 2006 18:41:41 -0500
- Subject: Re: RFA: ensure binary objects opened in binary mode
- References: <43F6473F.8030508@cwilson.fastmail.fm>
On Fri, Feb 17, 2006 at 04:59:27PM -0500, Charles Wilson wrote:
>2006-02-17 Charles Wilson <...>
>
> * gdb/solib.c(solib_open): ensure solib files are opened in
> binary mode.
I think this patch is a good idea but I'm wondering if we're doing the
#ifdef O_BINARY
# define O_BINARY 0
#endif
trick in too many source files. Maybe it's time for this to be in a header
file?
cgf