This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: ensure binary objects opened in binary mode
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Charles Wilson <cygwin at cwilson dot fastmail dot fm>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 18 Feb 2006 12:49:51 +0200
- Subject: Re: RFA: ensure binary objects opened in binary mode
- References: <43F6473F.8030508@cwilson.fastmail.fm>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Fri, 17 Feb 2006 16:59:27 -0500
> From: Charles Wilson <cygwin@cwilson.fastmail.fm>
>
> However, even on cygwin, it's still *wrong* for gdb to open a solib
> (which is by definition a binary object) in text mode -- even if it gets
> "fixed" later by bfd_open(). So IMO this patch is "the right thing" for
> both cygwin and mingw, even tho there is no observable change in
> cygwin's behavior -- and it DOES fix a serious bug on mingw.
This patch is fine with me, but I agree with Chris that the
definitions of O_BINARY should be unified in a header file, and the
definitions private to various *.c files removed. I suggested defs.h
as the header to put the one definition.
Thanks.