This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Allow spaces in filenames to load command
- From: "Jim Blandy" <jimb at red-bean dot com>
- To: "Andrew STUBBS" <andrew dot stubbs at st dot com>, "Jim Blandy" <jimb at red-bean dot com>, "GDB Patches" <gdb-patches at sourceware dot org>
- Date: Mon, 20 Feb 2006 11:59:42 -0800
- Subject: Re: [PATCH] Allow spaces in filenames to load command
- References: <43949300.1040203@st.com> <8f2776cb0512051250u2a6083dbma95e6b352410dea8@mail.gmail.com> <43956C93.5070709@st.com> <8f2776cb0512061504la4a7a5brada0edaeb051f0e4@mail.gmail.com> <8f2776cb0512061912o2d37bef9y7404a51858bfd6cf@mail.gmail.com> <43971EC3.3060405@st.com> <43972145.6020903@st.com> <20060220170702.GH16058@nevyn.them.org>
On 2/20/06, Daniel Jacobowitz <drow@false.org> wrote:
> On Wed, Dec 07, 2005 at 05:52:05PM +0000, Andrew STUBBS wrote:
> > 2005-12-07 Andrew Stubbs <andrew.stubbs@st.com>
> >
> > * symfile.c (generic_load): Use buildargv() and tilde_expand()
> > to parse file names with quoting, spaces and tildes properly.
> > (load_command): Quote all special characters before calling
> > target_load() such that buildargv() doesn't break file names.
> > (_initialize_symfile): Mention the load offset in the help for
> > the load command.
> > * remote-sim.c: Include readline.h.
> > (gdbsim_load): Use buildargv and tilde_expand() to parse file
> > names with quoting, spaces and tildes properly.
> > * target.h (target_load): Comment the parameters better.
> > * Makefile.in (remote_sim.o): Add readline.h dependency.
>
> This all looks plausible to me. Jim, do you want to take a look at
> this, since you were previously?
Yes --- this look good.
Ideally, the code added to load_command to do the quoting should be in
libiberty/argv.c. But this patch is fine as is.