This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: parse 'target remote' device special cases first
- From: Daniel Jacobowitz <drow at false dot org>
- To: Jim Blandy <jimb at red-bean dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sat, 25 Mar 2006 02:00:20 -0500
- Subject: Re: RFA: parse 'target remote' device special cases first
- References: <vt2bqwgscgf.fsf@theseus.home.>
On Wed, Mar 08, 2006 at 04:12:32PM -0800, Jim Blandy wrote:
>
> Without this change, if the command supplied after 'target remote |'
> contained a colon, the portion of the command ahead of that colon
> would be mistaken for a hostname. But the syntax isn't actually
> ambiguous, since hostnames don't start with '|'.
>
> Tested on x86_64-pc-linux-gnu.
>
> src/gdb/ChangeLog:
> 2006-03-08 Jim Blandy <jimb@red-bean.com>
>
> * serial.c (serial_open): Check for special cases at the front of
> the "device" name before scanning for the ':' that would indicate
> an IP-based connection.
Doesn't this go against the "what not why" ChangeLog convention? It
ought to go in serial_open as a comment, I think.
Other than that, I agree; this patch is OK.
--
Daniel Jacobowitz
CodeSourcery