This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] allow nested sourced commands


Andrew STUBBS wrote:
Michael Snyder wrote:

Well, it has the virtue of simplicity!
At first glance, it seems conceptually valid.

I think you need a clean-up, though. What if it errors?

Look again, more closely :) arg_cleanup IS a clean-up.

Ah. So it is. ;-)


Does that mean it is OK?

Hmmm, well, I'm not too familiar with that code, but it looks OK programatically. Certainly should be commented better, though, esp. since a struct called "user_args" now contains something that's not a user arg.

Can you add a test in the testsuite?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]