Re: PATCH: Disable ARM RDP

[Daniel Jacobowitz <drow at false dot org>]

On Fri, Mar 24, 2006 at 03:30:53PM -0500, Daniel Jacobowitz wrote:
> On Fri, Mar 17, 2006 at 02:25:42PM -0800, Mark Mitchell wrote:
> > 
> > This patch removes remote-rdp.o from ARM's TDEPFILES since Daniel and
> > Paul say that it's useless to most people.  I also found that with
> > --disable-sim GDB fails to link because remote-rdp.c references a
> > function defined in the simulator.
> > 
> > I'm not sure if this is the right patch for mainline, or whether
> > people would rather I remove remote-rdp.c entirely, or do nothing, or
> > ...  So, I guess this is a request for approval, but a pretty
> > tentative one.
> 
> > 	* gdb/config/arm/embed.mt (TDEPFILES): Remove remote-rdp.o.
> 
> Well, this patch isn't OK.  Afterwards remote-rdp is orphaned - no
> other configuration uses it.  So, either we are removing it, or we
> aren't.
> 
> I'm in favor of removing it.  Strikes against it:
> 
>   - It doesn't build with --disable-sim.
>   - It doesn't build on some versions of MinGW32, because it
>     references sleep().
>   - It's an old remote protocol and I haven't seen any reports of
>     it being used.
>   - Using RDP directly is even older than using RDI to talk to
>     the same devices, which we've already removed.
> 
> I have no real preference on removing it immediately versus marking it
> obsolete in the next release; the first two bullets are problems for
> CodeSourcery, but we can always turn it off in our release branch.
> But I'd like to do one or the other.  Anyone have a preference?

I didn't see any comments on this.  I'm pretty confident that no one
uses this protocol any more, so I would like to remove it, unless
anyone objects.

So, please speak up, if you object to "target rdp" being removed from
the arm-elf target.  No other triplet enables it.

(I had to apply a global interface change to remote-rdp.c today,
which reminded me.  Many of these remote targets I'm patching
deserve to be removed.  Let's make sure to get a complete list
before the next release...)

-- 
Daniel Jacobowitz
CodeSourcery