This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Reverse debugging, part 3/3: user interface / docs


> Date: Mon, 17 Apr 2006 16:44:55 -0700
> From: Michael Snyder <msnyder@redhat.com>
> CC: gdb-patches@sources.redhat.com
> 
> Please see revised patch, attached.
> OK now?

The corrections you made are okay, but you left two of my suggestions
unhandled, please at least explain why.

> >>+                                                 Behavior of 
> >>+ asynchronous signals depends on the target environment.
> > 
> > 
> > This is too vague.  Can we at least mention the possible behaviors, or
> > just the most common/expected ones?  The reader should get some idea
> > of what might happen.

You didn't change anything in response to this comment.

> >>+ Run the program backward until control reaches the start of a
> >>+ different source line
> > 
> > 
> > Isn't it better to say
> > 
> >   Run the program backwards until control reaches the first instruction
> >   of a different source line
> > 
> > ?  In any case, "backwards", not "backward".

You left "backward" in the text.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]