This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Remove type prefix for -var-evaluate-expression/functions
- From: Daniel Jacobowitz <drow at false dot org>
- To: Vladimir Prus <ghost at cs dot msu dot su>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 5 May 2006 16:47:46 -0400
- Subject: Re: Remove type prefix for -var-evaluate-expression/functions
- References: <17434.35140.456146.649459@kahikatea.snap.net.nz> <200603171319.55381.ghost@cs.msu.su> <20060317193702.GC19068@nevyn.them.org> <e0t6jb$700$1@sea.gmane.org>
On Tue, Apr 04, 2006 at 11:18:02AM +0400, Vladimir Prus wrote:
> The new version of the patch, with testsuite change, is attached.
>
> Changelog:
> 2006-03-15 Vladimir Prus <ghost@cs.msu.su>
>
> * c-valprint.c
> (c_val_print): Don't print type prefix for functions.
> (c_value_print): Print type prefix for functions here.
> * testsuite/gdb.mi/mi-var-cmd.exp: Test for new behaviour.
Hi Vladimir (do you prefer Volodya?),
This patch is fine. Please adjust the ChangeLog entry for GNU
formatting - I realize everyone else puts their asterisks in a
different place than we do:
* c-valprint.c (c_val_print): Don't print type prefix for functions.
(c_value_print): Print type prefix for functions here.
* gdb.mi/mi-var-cmd.exp: Test for printing functions.
Otherwise, feel free to check it in.
[You don't usually want to refer to "new behavior" in the testsuite
changelog entry, because it's tricky to go back and see what commit in
the gdb ChangeLog the test corresponds to. Yes, this is just CVS's
fault really.]
--
Daniel Jacobowitz
CodeSourcery