This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch for invalid hw breakpoints

On Thu, Jun 01, 2006 at 06:45:32PM +0100, Nathan Sidwell wrote:
> The remote stub can deal with this, but the functionality detection code in 
> remote.c cannot.  In particular this bit of code in 
> remote_remove_watchpoint triggers because the just attempted 
> remote_insert_watchpoint call has now set the support field to 
> PACKET_DISABLE.

Oh.  So, more like this:

-> Z2,11110000
<- [empty: I don't support that.]
tries to send: -> z2,11110000
[internal error, I already know I don't support that!]

That could be changed in remote.c, but not removing what we didn't
insert does seem cleaner.

-- 
Daniel Jacobowitz
CodeSourcery
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]