This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch] fix issues in some locales with using a-z


a bunch of files in gdb use a-z in sed expressions without forcing the locale 
to c ... in some locales, this can cause some pretty "fun" results:

(observer.sh)
In file included from solib.c:47:
observer.h:35: error: stray '@' in program
observer.h:35: error: expected ')' before 'deftypefun'

(Makefile.in:init.c)
libgdb.a(init.o): In function `initialize_all_files':
init.c:(.text+0xa): undefined reference to `_initialize_amd64_lin'
init.c:(.text+0xf): undefined reference to `_initialize_i386_'

i've fixed this issue in the Makefile.in, gdb_indent.sh, gdb_mbuild,sh, and 
observer.sh files the same way that gdbarch.sh was fixed oh-so-long ago 
rather than the over-the-top way that autoconf does it (see the top of 
gdb/configure under "NLS nuisances" to see what i mean)
-mike

Attachment: pgp00000.pgp
Description: PGP signature

2006-06-21  Mike Frysinger  <vapier@gentoo.org>:

	* Makefile.in (init.c) [LANG, LC_ALL]: Set to `c'.
	* gdb_indent.sh, gdb_mbuild.sh, observer.sh: Likewise

--- gdb/Makefile.in
+++ gdb/Makefile.in
@@ -1154,6 +1154,8 @@ init.c: $(INIT_FILES)
 	@rm -f init.c-tmp init.l-tmp
 	@touch init.c-tmp
 	@echo gdbtypes > init.l-tmp
+	LANG=c ; export LANG ; \
+	LC_ALL=c ; export LC_ALL ; \
 	@-echo $(INIT_FILES) | \
 	tr ' ' '\012' | \
 	sed \
--- gdb/gdb_indent.sh
+++ gdb/gdb_indent.sh
@@ -3,6 +3,11 @@
 # Try to find a GNU indent.  There could be a BSD indent in front of a
 # GNU gindent so when indent is found, keep looking.
 
+# Make certain that the script is running in an internationalized
+# environment.
+LANG=c ; export LANG
+LC_ALL=c ; export LC_ALL
+
 gindent=
 indent=
 paths=`echo $PATH | sed \
--- gdb/gdb_mbuild.sh
+++ gdb/gdb_mbuild.sh
@@ -22,6 +22,11 @@
 #  Foundation, Inc., 51 Franklin Street, Fifth Floor,
 #  Boston, MA  02111-1301, USA
 
+# Make certain that the script is running in an internationalized
+# environment.
+LANG=c ; export LANG
+LC_ALL=c ; export LC_ALL
+
 usage()
 {
     cat <<EOF
--- gdb/observer.sh
+++ gdb/observer.sh
@@ -1,5 +1,10 @@
 #!/bin/sh -e
 
+# Make certain that the script is running in an internationalized
+# environment.
+LANG=c ; export LANG
+LC_ALL=c ; export LC_ALL
+
 if test $# -ne 3
 then
     echo "Usage: $0 <h|inc> <observer.texi> <observer.out>" 1>&2

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]