This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [cosmetic-patch] missing declaration in monitor.c

From: Denis PILAT <denis dot pilat at st dot com>
To: Daniel Jacobowitz <drow at false dot org>
Cc: gdb-patches at sources dot redhat dot com
Date: Mon, 17 Jul 2006 14:50:05 +0200
Subject: Re: [cosmetic-patch] missing declaration in monitor.c
References: <44BB751B.10608@st.com> <20060717123228.GA8764@nevyn.them.org>

Daniel Jacobowitz wrote:

On Mon, Jul 17, 2006 at 01:31:39PM +0200, Denis PILAT wrote:

monitor_insert_breakpoint and monitor_remove_breakpoint used to be declared with other static function.
Yes, I deliberately removed the prototypes instead of changing them.
Did you need them back for a reason?  There's no advantage in modern
C to prototyping a static function if it is not used before it is
defined.

No I don't need them. While reading the code I found that they were missing because all other static function are declared. I'm wondering why you remove only these 2 one ? Most of static functions are not used before beeing defined.

Follow-Ups:
- Re: [cosmetic-patch] missing declaration in monitor.c
  - From: Daniel Jacobowitz

References:
- [cosmetic-patch] missing declaration in monitor.c
  - From: Denis PILAT
- Re: [cosmetic-patch] missing declaration in monitor.c
  - From: Daniel Jacobowitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]