This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] PR mi/2086 -break-insert missing error diagnostic
- From: Nick Roberts <nickrob at snap dot net dot nz>
- To: gdb-patches at sources dot redhat dot com
- Date: Wed, 18 Oct 2006 10:07:14 +1300
- Subject: [PATCH] PR mi/2086 -break-insert missing error diagnostic
This patch fixes PR mi/2086. There may be similar bugs arising from using
catch_exceptions_with_msg inappropriately.
I could slowly work my way through the mi PRs in the bug database. Can I close
a bug or is that another level? (I don't know my password, if I have one).
--
Nick http://www.inet.net.nz/~nickrob
*** gdb.h 18 Dec 2005 11:33:59 +1300 1.5
--- gdb.h 18 Oct 2006 02:57:25 +1300
***************
*** 53,60 ****
/* Create a breakpoint at ADDRESS (a GDB source and line). */
enum gdb_rc gdb_breakpoint (char *address, char *condition,
int hardwareflag, int tempflag,
! int thread, int ignore_count,
! char **error_message);
/* Switch thread and print notification. */
enum gdb_rc gdb_thread_select (struct ui_out *uiout, char *tidstr,
--- 53,59 ----
/* Create a breakpoint at ADDRESS (a GDB source and line). */
enum gdb_rc gdb_breakpoint (char *address, char *condition,
int hardwareflag, int tempflag,
! int thread, int ignore_count);
/* Switch thread and print notification. */
enum gdb_rc gdb_thread_select (struct ui_out *uiout, char *tidstr,
*** breakpoint.c 09 Aug 2006 09:32:37 +1200 1.229
--- breakpoint.c 18 Oct 2006 03:04:02 +1300
*************** do_captured_breakpoint (struct ui_out *u
*** 5466,5473 ****
enum gdb_rc
gdb_breakpoint (char *address, char *condition,
int hardwareflag, int tempflag,
! int thread, int ignore_count,
! char **error_message)
{
struct captured_breakpoint_args args;
args.address = address;
--- 5466,5472 ----
enum gdb_rc
gdb_breakpoint (char *address, char *condition,
int hardwareflag, int tempflag,
! int thread, int ignore_count)
{
struct captured_breakpoint_args args;
args.address = address;
*************** gdb_breakpoint (char *address, char *con
*** 5476,5483 ****
args.tempflag = tempflag;
args.thread = thread;
args.ignore_count = ignore_count;
! return catch_exceptions_with_msg (uiout, do_captured_breakpoint, &args,
! error_message, RETURN_MASK_ALL);
}
--- 5475,5481 ----
args.tempflag = tempflag;
args.thread = thread;
args.ignore_count = ignore_count;
! return do_captured_breakpoint (uiout, &args);
}