This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR mi/2086 -break-insert missing error diagnostic


On Wed, Oct 18, 2006 at 10:07:14AM +1300, Nick Roberts wrote:
> 
> This patch fixes PR mi/2086.  There may be similar bugs arising from using
> catch_exceptions_with_msg inappropriately.

Is this the whole patch?  I guess you updated the caller too.

I think removing catch_exceptions_with_msg isn't enough - if you look
at the call site, it's not prepared for an error() to escape there.
It would have to use a cleanup for deprecated_set_gdb_event_hooks.

Ulrich posted a detailed analysis of this to gdb@ on Oct. 4th.  I think
it was just a buggy conversion to catch_exceptions_with_msg; we should
check everywhere touched by whatever patch that was.  Looks like it was
from 2005-01-13.

> I could slowly work my way through the mi PRs in the bug database.  Can I close
> a bug or is that another level? (I don't know my password, if I have one).

I'll send it offlist.  Feel free to close bugs.


-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]