This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: MI: -var-list-children --simple-values
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: Nick Roberts <nickrob at snap dot net dot nz>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 15 Nov 2006 14:50:19 +0300
- Subject: Re: MI: -var-list-children --simple-values
- References: <200611151250.11654.vladimir@codesourcery.com> <17754.63307.487745.34360@kahikatea.snap.net.nz>
On Wednesday 15 November 2006 14:17, Nick Roberts wrote:
> > -var-list-children --simple-values
> >
> > is broken on mainline. Printing children of any C++ structure results in
> > segfault. The problem is that C++ structures have "public" fake child
> > that has no type, so mi_print_value_p tries to access properties of a
> > NULL type.
> >
> > This is easy to fix, but given that printing C++ structures is a
> > mainstream use-case, and no IDE developer ever complained, this suggests
> > that this feature is not used. Rather than carry it along, how about
> > just removing it?
>
> ISTR Daniel J wanted --simple-values for consistency with
> -stack-list-locals. As it's easy to fix, I suggest doing that.
There are many things that are easy to fix, but it does not mean we need to
keep unused functionality.
Perhaps Dan can comment why he really needed --simple-values.
> I also note
> a mistake in the error message. Both are fixed below.
I don't see any regression test for this crash. Are you going to provide one?
- Volodya