This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Remote protocol g/G/p/P packet cleanups


On Thu, Nov 09, 2006 at 03:05:57PM -0500, Daniel Jacobowitz wrote:
> 2006-11-09  Daniel Jacobowitz  <dan@codesourcery.com>
> 
> 	* remote.c (struct remote_arch_state): Doc fix.
> 	(compare_pnums): New function.
> 	(init_remote_state): Only allocate packet_reg structures for raw
> 	registers.  Define the g/G packet format separately from creating
> 	packet_reg.  Don't use DEPRECATED_REGISTER_BYTE.
> 	(packet_reg_from_regnum, packet_reg_from_pnum): Only iterate over
> 	raw registers.
> 	(register_bytes_found): Delete.
> 	(fetch_register_using_p): Take a struct packet_reg.  Handle disabled
> 	'p' packet here.  Use packet_ok.
> 	(fetch_registers_using_g): New function, split out of
> 	remote_fetch_registers.  Check the 'g' packet more strictly.  Save
> 	its actual size and contents.  Eliminate BUF.  Only iterate over
> 	raw registers.
> 	(remote_fetch_registers): Use the new functions for 'p' and 'g'.
> 	Mark unavailable registers.
> 	(store_register_using_P): Likewise to fetch_register_using_p.
> 	(store_registers_using_G): New function, split out of
> 	remote_store_registers.  Only iterate over raw registers.  Don't
> 	use register_bytes_found.
> 	(remote_store_registers): Likewise to remote_fetch_registers.

I've checked in this cleanup.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]