This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list
- From: Daniel Jacobowitz <drow at false dot org>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: Chet Ramey <chet dot ramey at case dot edu>, GDB <gdb-patches at sources dot redhat dot com>, jkratoch at redhat dot com, bug-readline at gnu dot org, chet at case dot edu
- Date: Sat, 2 Dec 2006 18:05:58 -0500
- Subject: Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list
- References: <20061121213205.GA13310@lucon.org> <20061128164658.GB20882@nevyn.them.org> <20061128165844.GA13667@lucon.org> <20061202184344.GA2197@lucon.org> <4571CF2A.3040608@case.edu> <20061202221541.GA9776@lucon.org>
On Sat, Dec 02, 2006 at 02:15:41PM -0800, H. J. Lu wrote:
> > There should be no reason that the application cannot remove the callback
> > handler and re-add it before calling readline synchronously, as Daniel or
> > H.J. suggested. The application is the only one in a position to know
> > which is right.
> >
>
> Did you mean
>
> http://sources.redhat.com/ml/gdb-patches/2006-11/msg00234.html
>
> is more appropriate?
HJ, did you even read my response?
Messing about with RL_SETSTATE and RL_UNSETSTATE in GDB is not wise and
we should not be doing it. We should be manually removing our
callbacks before we call readline synchronously, as I wrote in reply to
your message. Someone is going to need to really understand the
different paths that take us into readline to work out where to do it.
--
Daniel Jacobowitz
CodeSourcery