This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2] Fix gdb.mi/mi-file.exp for stubs.
Pedro Alves escreveu:
Pedro Alves escreveu:
Hi all,
There is a comment on mi-file.exp that says:
# get the path and absolute path to the current executable
#
# In gdb 6.2 (at least), the default line number is set by
# select_source_symtab to the first line of "main" minus
# the value of "lines_to_list" (which defaults to 10) plus one.
# --chastain 2004-08-13
That won't work for remote stubs.
The attached patch adds a call to mi_run_to_main with the following
comment:
# When debugging a stub, we can't depend on the current file
# being the default file set by select_source_symtab.
# When the gdb host connects to the stub, the stub will already be
# running the target program stopped at a function
# that probably isn't the one with main. We force
# the file with main to be the current, so the following tests work.
I withdraw this patch. It doesn't fix anything... I misread the
testresults. Sorry for the noise.
Instead, I propose skipping the test when running the testsuite against
a stub.
Also, the mi2-file.exp test has the same problem.
This version doesn't skip the test and also passes on stubs.
It does that by calling mi_gdb_file_cmd instead of mi_gdb_load.
Since it doesn't connect to the target, the default file is still the
the current one.
Please find a new patch attached, review and commit.
Cheers,
Pedro Alves
---
2006-12-14 Pedro Alves <pedro_alves@portugalmail.pt>
* gdb.mi/mi-file.exp: Use mi_gdb_file_cmd instead of mi_gdb_load.
* gdb.mi/mi2-file.exp: Likewise.
Index: mi-file.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-file.exp,v
retrieving revision 1.7
diff -u -p -r1.7 mi-file.exp
--- mi-file.exp 12 Sep 2006 20:11:42 -0000 1.7
+++ mi-file.exp 14 Dec 2006 09:54:32 -0000
@@ -43,7 +43,7 @@ if { [gdb_compile "${srcdir}/${subdir}/
mi_delete_breakpoints
mi_gdb_reinitialize_dir $srcdir/$subdir
-mi_gdb_load ${binfile}
+mi_gdb_file_cmd ${binfile}
proc test_file_list_exec_source_file {} {
global srcfile
Index: mi2-file.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-file.exp,v
retrieving revision 1.7
diff -u -p -r1.7 mi2-file.exp
--- mi2-file.exp 10 Aug 2006 05:27:21 -0000 1.7
+++ mi2-file.exp 14 Dec 2006 09:54:32 -0000
@@ -43,7 +43,7 @@ if { [gdb_compile "${srcdir}/${subdir}/
mi_delete_breakpoints
mi_gdb_reinitialize_dir $srcdir/$subdir
-mi_gdb_load ${binfile}
+mi_gdb_file_cmd ${binfile}
proc test_file_list_exec_source_file {} {
global srcfile